Review Request 129010: kded: remove dbus calls to ksplash.

David Faure faure at kde.org
Sun Sep 25 10:08:00 UTC 2016



> On Sept. 24, 2016, 12:15 p.m., Luigi Toscano wrote:
> > Wouldn't this break the compatibility with older Plasma (one can argue that Plasma should be updated, but it's a behavioral change).

Yes it would. Can you suggest an appropriate time frame for this cleanup? I was hoping two plasma releases (5.7 and 5.8) was OK, I can wait more, but I'd like to keep cleaning up kded from workspace stuff at some point, it really doesn't belong there.


- David


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129010/#review99501
-----------------------------------------------------------


On Sept. 24, 2016, 12:09 p.m., David Faure wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129010/
> -----------------------------------------------------------
> 
> (Updated Sept. 24, 2016, 12:09 p.m.)
> 
> 
> Review request for KDE Frameworks and David Edmundson.
> 
> 
> Repository: kded
> 
> 
> Description
> -------
> 
> Not needed anymore since June (b6058a0 in plasma-workspace, i.e. Plasma 5.7).
> 
> 
> Diffs
> -----
> 
>   src/kded.cpp 6b3ec1e93f5c1ae3620204190af2c8cee3736a11 
> 
> Diff: https://git.reviewboard.kde.org/r/129010/diff/
> 
> 
> Testing
> -------
> 
> None.
> 
> 
> Thanks,
> 
> David Faure
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160925/ac24a4ef/attachment.html>


More information about the Kde-frameworks-devel mailing list