Review Request 128768: Directly show detailsGroup for KMessageBox::detailedSorry by default

[Leslie Zhai]

> On 九月 15, 2016, 9:41 p.m., Kai Uwe Broulik wrote:
> > tests/kmessageboxtest.cpp, line 232
> > <https://git.reviewboard.kde.org/r/128768/diff/1/?file=475432#file475432line232>
> >
> >     QString QString::repeated(int times) const
> >     
> >     Returns a copy of this string repeated the specified number of times.
> 
> Anthony Fieroni wrote:
>     Fix it here https://api.kde.org/frameworks/kwidgetsaddons/html/kmessagebox_8cpp_source.html#l00200

Hi Anthony,

Thanks for your hint, I will try to fix it ;-)

Regards,
Leslie Zhai


- Leslie


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128768/#review99217
-----------------------------------------------------------


On 九月 18, 2016, 10 a.m., Leslie Zhai wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128768/
> -----------------------------------------------------------
> 
> (Updated 九月 18, 2016, 10 a.m.)
> 
> 
> Review request for KDE Frameworks and David Faure.
> 
> 
> Bugs: 366569
>     https://bugs.kde.org/show_bug.cgi?id=366569
> 
> 
> Repository: kwidgetsaddons
> 
> 
> Description
> -------
> 
> Hi David,
> 
> K3B use KMessageBox::detailedSorry to show message for not support protocol such as add files from samba, but KMessageBox::detailedSorry hide some part of detailsGroup https://pbs.twimg.com/media/CqxlXX1W8AAtoee.jpg so it is better to show it directly by default!
> 
> Regards,
> Leslie Zhai
> 
> 
> Diffs
> -----
> 
>   tests/kmessageboxtest.cpp 8ea2848 
> 
> Diff: https://git.reviewboard.kde.org/r/128768/diff/
> 
> 
> Testing
> -------
> 
> add case 26 in the patch, for long (> 512) details:
> 
> kwidgetsaddons/build/tests/kmessageboxtest 26
> 
> 
> Thanks,
> 
> Leslie Zhai
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160918/55f7fb1a/attachment.html>