Review Request 128768: Directly show detailsGroup for KMessageBox::detailedSorry by default
Leslie Zhai
xiangzhai83 at gmail.com
Sun Sep 18 02:00:15 UTC 2016
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128768/
-----------------------------------------------------------
(Updated 九月 18, 2016, 10 a.m.)
Review request for KDE Frameworks and David Faure.
Changes
-------
Hide the detailed group by default, and use repeated as textcase.
Bugs: 366569
https://bugs.kde.org/show_bug.cgi?id=366569
Repository: kwidgetsaddons
Description
-------
Hi David,
K3B use KMessageBox::detailedSorry to show message for not support protocol such as add files from samba, but KMessageBox::detailedSorry hide some part of detailsGroup https://pbs.twimg.com/media/CqxlXX1W8AAtoee.jpg so it is better to show it directly by default!
Regards,
Leslie Zhai
Diffs (updated)
-----
tests/kmessageboxtest.cpp 8ea2848
Diff: https://git.reviewboard.kde.org/r/128768/diff/
Testing
-------
add case 26 in the patch, for long (> 512) details:
kwidgetsaddons/build/tests/kmessageboxtest 26
Thanks,
Leslie Zhai
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160918/e2473027/attachment.html>
More information about the Kde-frameworks-devel
mailing list