Review Request 128768: Directly show detailsGroup for KMessageBox::detailedSorry by default

[Kai Uwe Broulik]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128768/#review99217
-----------------------------------------------------------



-1

The details group is hidden by default for a reason and shouldn't contain vital information. It shouldn't be cut off, though, but properly collapsed and all. Or do I misunderstood what this patch is about?


tests/kmessageboxtest.cpp (line 232)
<https://git.reviewboard.kde.org/r/128768/#comment66805>

    QString QString::repeated(int times) const
    
    Returns a copy of this string repeated the specified number of times.


- Kai Uwe Broulik


On Sept. 15, 2016, 10:52 vorm., Leslie Zhai wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128768/
> -----------------------------------------------------------
> 
> (Updated Sept. 15, 2016, 10:52 vorm.)
> 
> 
> Review request for KDE Frameworks and David Faure.
> 
> 
> Bugs: 366569
>     https://bugs.kde.org/show_bug.cgi?id=366569
> 
> 
> Repository: kwidgetsaddons
> 
> 
> Description
> -------
> 
> Hi David,
> 
> K3B use KMessageBox::detailedSorry to show message for not support protocol such as add files from samba, but KMessageBox::detailedSorry hide some part of detailsGroup https://pbs.twimg.com/media/CqxlXX1W8AAtoee.jpg so it is better to show it directly by default!
> 
> Regards,
> Leslie Zhai
> 
> 
> Diffs
> -----
> 
>   src/kmessagebox.cpp 194ffae 
>   tests/kmessageboxtest.cpp 8ea2848 
> 
> Diff: https://git.reviewboard.kde.org/r/128768/diff/
> 
> 
> Testing
> -------
> 
> add case 26 in the patch, for long (> 512) details:
> 
> kwidgetsaddons/build/tests/kmessageboxtest 26
> 
> 
> Thanks,
> 
> Leslie Zhai
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160915/9d1e9107/attachment.html>