Review Request 128768: Directly show detailsGroup for KMessageBox::detailedSorry by default

[Leslie Zhai]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128768/
-----------------------------------------------------------

(Updated Sept. 15, 2016, 10:52 a.m.)


Review request for KDE Frameworks and David Faure.


Bugs: 366569
    https://bugs.kde.org/show_bug.cgi?id=366569


Repository: kwidgetsaddons


Description
-------

Hi David,

K3B use KMessageBox::detailedSorry to show message for not support protocol such as add files from samba, but KMessageBox::detailedSorry hide some part of detailsGroup https://pbs.twimg.com/media/CqxlXX1W8AAtoee.jpg so it is better to show it directly by default!

Regards,
Leslie Zhai


Diffs
-----

  src/kmessagebox.cpp 194ffae 
  tests/kmessageboxtest.cpp 8ea2848 

Diff: https://git.reviewboard.kde.org/r/128768/diff/


Testing
-------

add case 26 in the patch, for long (> 512) details:

kwidgetsaddons/build/tests/kmessageboxtest 26


Thanks,

Leslie Zhai

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160915/888c0477/attachment-0001.html>