Review Request/New Framework: KF5::SyntaxHighlighting

[Volker Krause]

On Sunday 11 September 2016 05:33:29 Michael Palimaka wrote:
> On 11/09/16 01:47, Volker Krause wrote:
> > please review KF5::SyntaxHighlighting (syntax-highlighting in Git) for
> > becoming a framework :)
> 
> Thanks a lot for working on this.
> 
> I noticed that KF5SyntaxHighlightingConfig.cmake.in searches for
> Qt5Widgets, but that doesn't seem to used in any public part of the
> framework (only tests). 

indeed, fixed.


> Also, some tests are failing here.

did you maybe download updated syntax definitions, or have those installed via 
Kate already? If so, that indeed broke the tests, that should be fixed now 
though. If the tests still fail for you, please send me some more details, in 
particular the full output.

Thanks!
Volker
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 173 bytes
Desc: This is a digitally signed message part.
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160911/e0cf437e/attachment.sig>