Review Request 128865: baloo_file crash fix - if database can't be created, try to cleanup and recreate
Christoph Cullmann
cullmann at kde.org
Thu Sep 8 21:59:09 UTC 2016
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128865/
-----------------------------------------------------------
(Updated Sept. 8, 2016, 9:59 p.m.)
Review request for KDE Frameworks and David Faure.
Repository: baloo
Description
-------
ATM, I think baloo is missing a lot of checks for "mdb has seen problems".
Easiest case: you have a corrupted index database (easy to reproduce: echo BLA >> index in the baloo .local/... directory)
=> start baloo_file => directly crashs
Fix: try to create db, honor success, cleanup, try to create again, if still broken => exit
Diffs (updated)
-----
src/file/main.cpp 9410635
Diff: https://git.reviewboard.kde.org/r/128865/diff/
Testing
-------
Corrupted DB via
[cullmann at gekko baloo]$ pwd
/home/cullmann/.local/share/baloo
[cullmann at gekko baloo]$ echo skljdflksjdf >> index
=> started baloo_file
=> old version: will segfault for ever on each start
=> new version: works after cleanup
Thanks,
Christoph Cullmann
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160908/b87f2d3e/attachment.html>
More information about the Kde-frameworks-devel
mailing list