Review Request 128865: baloo_file crash fix - if database can't be created, try to cleanup and recreate

[David Faure]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128865/#review99006
-----------------------------------------------------------



Looks nice.


src/file/main.cpp (line 91)
<https://git.reviewboard.kde.org/r/128865/#comment66677>

    openable? not sure this exists in English.
        "[...], removing corrupted database" << path;
    might be clearer anyway.



src/file/main.cpp (line 98)
<https://git.reviewboard.kde.org/r/128865/#comment66678>

    Failed to create database after deleting corrupted one.


- David Faure


On Sept. 8, 2016, 9:49 p.m., Christoph Cullmann wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128865/
> -----------------------------------------------------------
> 
> (Updated Sept. 8, 2016, 9:49 p.m.)
> 
> 
> Review request for KDE Frameworks and David Faure.
> 
> 
> Repository: baloo
> 
> 
> Description
> -------
> 
> ATM, I think baloo is missing a lot of checks for "mdb has seen problems".
> 
> Easiest case: you have a corrupted index database (easy to reproduce: echo BLA >> index in the baloo .local/... directory)
> 
> => start baloo_file => directly crashs
> 
> Fix: try to create db, honor success, cleanup, try to create again, if still broken => exit
> 
> 
> Diffs
> -----
> 
>   src/file/main.cpp 9410635 
> 
> Diff: https://git.reviewboard.kde.org/r/128865/diff/
> 
> 
> Testing
> -------
> 
> Corrupted DB via
> 
> [cullmann at gekko baloo]$ pwd
> /home/cullmann/.local/share/baloo
> [cullmann at gekko baloo]$ echo skljdflksjdf >> index
> 
> => started baloo_file
> 
> => old version: will segfault for ever on each start
> => new version: works after cleanup
> 
> 
> Thanks,
> 
> Christoph Cullmann
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160908/608bfb7c/attachment.html>