Review Request 128814: Add Qt5Network as a public dependency.

[Michael Palimaka]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128814/
-----------------------------------------------------------

(Updated Sept. 2, 2016, 6:15 p.m.)


Status
------

This change has been marked as submitted.


Review request for KDE Frameworks.


Changes
-------

Submitted with commit 99f220a81e82b2114f408823cdaa13a002e4fae5 by Michael Palimaka to branch master.


Repository: attica


Description
-------

Attica uses Qt5Network in its public API, so it must declare it as a public
dependency otherwise consumers could fail to build if Qt5Network is not already
found elsewhere in the dependency tree.


Diffs
-----

  KF5AtticaConfig.cmake.in 078d03c416316fc446b40405cb35f23665f5ed86 

Diff: https://git.reviewboard.kde.org/r/128814/diff/


Testing
-------

Consider this test case:

```cmake
project(test)
find_package(ECM 1.7.0 REQUIRED NO_MODULE)
find_package(KF5Attica REQUIRED)

set(test_SRCS test.cpp)
add_executable(test ${test_SRCS})
target_link_libraries(test KF5::Attica)
```

Before the change it fails to build with ``ld: cannot find -lQt5::Network``, after the change it passes.


Thanks,

Michael Palimaka

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160902/bebe5542/attachment.html>