Review Request 127275: Ki18n: Fallback to QLocale::system uiLanguages in language initalisation

[Friedrich W. H. Kossebau]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127275/#review98823
-----------------------------------------------------------




src/klocalizedstring.cpp (line 141)
<https://git.reviewboard.kde.org/r/127275/#comment66520>

    QLocale::uiLanguages() seems to not return names in gettext compatible format, but instead uses BCP47.
    And BCP47 cannot simply be converted to gettext locale codes by replacing - with _, that only works for "language-region" codes, but will fail once other elements of BCP47 are used.
    
    No idea about Windows in general, but this is one of the changes to Ki18n in the commit span which resulted in the regression https://bugs.kde.org/show_bug.cgi?id=368007
    
    Andre, could you perhaps have a look and/or comment on the bug report? Thanks.
    
    And perhaps add a comment to this code block in ki18n about it's fragile state :)


- Friedrich W. H. Kossebau


On March 8, 2016, 11:34 a.m., Andre Heinecke wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127275/
> -----------------------------------------------------------
> 
> (Updated March 8, 2016, 11:34 a.m.)
> 
> 
> Review request for KDE Frameworks and Localization and Translation (l10n).
> 
> 
> Repository: ki18n
> 
> 
> Description
> -------
> 
> The intention for this patch is to fix the inital Language selection for Windows where the environment variables used in Ki18n are not set.
> This is not a fix for a regression in Ki18n, afaik this never worked on Windows, we had some hacks in Gpg4win to write the language into kdeglobals during installation in kde4 times.
> 
> I don't think this needs to be ifdefed because it only appends so previous language selection is not affected.
> 
> 
> Diffs
> -----
> 
>   src/klocalizedstring.cpp b24fe9b 
> 
> Diff: https://git.reviewboard.kde.org/r/127275/diff/
> 
> 
> Testing
> -------
> 
> Tested on a german Windows system and got a "de" localized application.
> 
> 
> Thanks,
> 
> Andre Heinecke
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160901/75146324/attachment.html>