Review Request 129170: Add KArchive::errorString() method to provide more details on KArchive errors

[David Faure]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129170/#review100413
-----------------------------------------------------------




autotests/karchivetest.cpp (line 369)
<https://git.reviewboard.kde.org/r/129170/#comment67389>

    the additional parenthesis around tr are not needed



src/k7zip.cpp (line 2306)
<https://git.reviewboard.kde.org/r/129170/#comment67390>

    typo: undelying => underlying



src/k7zip.cpp (line 2369)
<https://git.reviewboard.kde.org/r/129170/#comment67391>

    tr() missing



src/k7zip.cpp (line 2499)
<https://git.reviewboard.kde.org/r/129170/#comment67392>

    Translators (and users) won't know what CTime is, but oh well, not many people know anyway ;)



src/k7zip.cpp (line 2588)
<https://git.reviewboard.kde.org/r/129170/#comment67393>

    tr() missing



src/karchive.cpp (line 403)
<https://git.reviewboard.kde.org/r/129170/#comment67394>

    indentation should be 4 spaces, this looks like 2



src/ktar.cpp (line 587)
<https://git.reviewboard.kde.org/r/129170/#comment67395>

    %1? missing arg()?


- David Faure


On Oct. 27, 2016, 2:23 a.m., Romário Rios wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129170/
> -----------------------------------------------------------
> 
> (Updated Oct. 27, 2016, 2:23 a.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: karchive
> 
> 
> Description
> -------
> 
> This method is similar to `QIODevice::errorString()`. I added a public `errorString()` method and a protected `setErrorString()` method, to allow `KArchive`'s subclasses to implement their own error messages. I also implemented most error messages from most subclasses.
> 
> 
> Diffs
> -----
> 
>   autotests/karchivetest.cpp d0fbf41 
>   src/k7zip.h 5b95f49 
>   src/k7zip.cpp 692b1db 
>   src/kar.h 85bd650 
>   src/kar.cpp 7204fb1 
>   src/karchive.h b528a4a 
>   src/karchive.cpp a1a160a 
>   src/karchive_p.h 256620d 
>   src/krcc.h 18c7d00 
>   src/krcc.cpp 1947dd6 
>   src/ktar.h 4bca898 
>   src/ktar.cpp f70b155 
>   src/kzip.h 84156c7 
>   src/kzip.cpp 94d4276 
> 
> Diff: https://git.reviewboard.kde.org/r/129170/diff/
> 
> 
> Testing
> -------
> 
> I added `QVERIFY` calls after all errors in `karchivetests.cpp`. Perhaps we'll need more tests, but I'm not sure how to make an archive to fail in some specific way aside from the very basics ("file not found", etc.).
> 
> 
> Thanks,
> 
> Romário Rios
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20161030/1c38404d/attachment.html>