Review Request 129172: kioexec: use friendly names
Elvis Angelaccio
elvis.angelaccio at kde.org
Thu Oct 13 12:38:40 UTC 2016
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129172/
-----------------------------------------------------------
Review request for KDE Frameworks and David Faure.
Repository: kio
Description
-------
kioexec currently creates temp files using the following filename scheme: `<pid>_<counter>_<filename>`. So users get a filename different from what they expected (just the filename, without random numbers).
This patch moves the pid and counter numbers in a folder that contains the temp file (with the origin filename). On cleanup, we make sure to delete also this folder.
Diffs
-----
src/kioexec/main.cpp 0a5352ebb91ab0b29bfdf97f3b234dbb01c162fe
Diff: https://git.reviewboard.kde.org/r/129172/diff/
Testing
-------
* Open a remote url with a non-kio app, e.g. a gdrive:// Google Doc file with Libreoffice.
* Check the filename in the app window title.
* Check that temp file and folder (in .cache/kioexec/krun) are deleted after the 3 minutes delay.
Thanks,
Elvis Angelaccio
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20161013/293cd2c7/attachment.html>
More information about the Kde-frameworks-devel
mailing list