Review Request 129162: Fix focus ownership if url is changed before showing the widget

[Albert Astals Cid]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129162/
-----------------------------------------------------------

(Updated Oct. 13, 2016, 10:08 p.m.)


Status
------

This change has been marked as submitted.


Review request for KDE Frameworks and David Faure.


Changes
-------

Submitted with commit 4108fd1b90630c9faaf38da34d4ed2c60d9ba657 by Albert Astals Cid to branch master.


Repository: kio


Description
-------

?


Diffs
-----

  autotests/CMakeLists.txt 2deb367 
  autotests/kfilewidgettest.cpp PRE-CREATION 
  src/filewidgets/kfilewidget.cpp 088aa79 

Diff: https://git.reviewboard.kde.org/r/129162/diff/


Testing
-------

See the test, testFocusOnLocationEditChangeDir2 passes both with and without the patch but testFocusOnLocationEditChangeDir does not, and they basically do the same just in a different order.

Also kate + Ctrl+O now does correctly focus on the "name" lineedit the first time instead of on the kdiroperator


Thanks,

Albert Astals Cid

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20161013/989dbc43/attachment.html>