Review Request 129162: Fix focus ownership if url is changed before showing the widget
David Faure
faure at kde.org
Thu Oct 13 17:49:23 UTC 2016
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129162/#review99989
-----------------------------------------------------------
Fix it, then Ship it!
Looks good to me!
autotests/kfilewidgettest.cpp (line 44)
<https://git.reviewboard.kde.org/r/129162/#comment67155>
QVERIFY is better than Q_ASSERT in unittests.
- David Faure
On Oct. 13, 2016, 5:44 p.m., Albert Astals Cid wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129162/
> -----------------------------------------------------------
>
> (Updated Oct. 13, 2016, 5:44 p.m.)
>
>
> Review request for KDE Frameworks and David Faure.
>
>
> Repository: kio
>
>
> Description
> -------
>
> ?
>
>
> Diffs
> -----
>
> autotests/CMakeLists.txt 2deb367
> autotests/kfilewidgettest.cpp PRE-CREATION
> src/filewidgets/kfilewidget.cpp 088aa79
>
> Diff: https://git.reviewboard.kde.org/r/129162/diff/
>
>
> Testing
> -------
>
> See the test, testFocusOnLocationEditChangeDir2 passes both with and without the patch but testFocusOnLocationEditChangeDir does not, and they basically do the same just in a different order.
>
> Also kate + Ctrl+O now does correctly focus on the "name" lineedit the first time instead of on the kdiroperator
>
>
> Thanks,
>
> Albert Astals Cid
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20161013/0ed31ebd/attachment.html>
More information about the Kde-frameworks-devel
mailing list