Review Request 129083: [KIconLoader] Take into account devicePixelRatio for overlays

Kai Uwe Broulik kde at privat.broulik.de
Sun Oct 2 21:29:27 UTC 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129083/
-----------------------------------------------------------

(Updated Okt. 2, 2016, 9:29 nachm.)


Review request for Dolphin, KDE Frameworks and David Edmundson.


Changes
-------

* Scale margins around overlay with dpr as well


Bugs: 369640
    https://bugs.kde.org/show_bug.cgi?id=369640


Repository: kiconthemes


Description
-------

Keeps them from being painted outside view and scales them with the image they're supposed to be painted on.


Diffs (updated)
-----

  src/kiconloader.cpp 5315ea4 

Diff: https://git.reviewboard.kde.org/r/129083/diff/


Testing
-------

Ran dolphin with device pixel ratio 2, got my symolic link icon again.
Ran it with device pixel ratio 1, looked as it did before.

(couldn't figure out why the VCS icons don't show up though)


Thanks,

Kai Uwe Broulik

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20161002/4f2ff679/attachment.html>


More information about the Kde-frameworks-devel mailing list