Review Request 129083: [KIconLoader] Take into account devicePixelRatio for overlays

[David Edmundson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129083/#review99712
-----------------------------------------------------------




src/kiconloader.cpp (line 538)
<https://git.reviewboard.kde.org/r/129083/#comment67037>

    if startPoint is now in device pixels for the dutaiton the course of the switch, the 2 needs multiplying by dpr too.


- David Edmundson


On Oct. 2, 2016, 3:56 p.m., Kai Uwe Broulik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129083/
> -----------------------------------------------------------
> 
> (Updated Oct. 2, 2016, 3:56 p.m.)
> 
> 
> Review request for Dolphin, KDE Frameworks and David Edmundson.
> 
> 
> Bugs: 369640
>     https://bugs.kde.org/show_bug.cgi?id=369640
> 
> 
> Repository: kiconthemes
> 
> 
> Description
> -------
> 
> Keeps them from being painted outside view and scales them with the image they're supposed to be painted on.
> 
> 
> Diffs
> -----
> 
>   src/kiconloader.cpp 5315ea4 
> 
> Diff: https://git.reviewboard.kde.org/r/129083/diff/
> 
> 
> Testing
> -------
> 
> Ran dolphin with device pixel ratio 2, got my symolic link icon again.
> Ran it with device pixel ratio 1, looked as it did before.
> 
> (couldn't figure out why the VCS icons don't show up though)
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20161002/e9d6119b/attachment.html>