Review Request 129399: Take X-KDE-RunOnDiscreteGpu property into account when starting app using KRun

[Jan Grulich]

> On Lis. 26, 2016, 7:20 odp., David Faure wrote:
> > src/widgets/krun.cpp, line 436
> > <https://git.reviewboard.kde.org/r/129399/diff/2/?file=486397#file486397line436>
> >
> >     Is it needed to do this check more than once?
> >     If this can't change over time, there could be a static enum here (not check yet, present, absent) to avoid making a dbus blocking call every time.

I'm not sure how to do that as static variables cannot be mutable thus I need to initialize it immediately and cannot change later. I'm also not able to put it into KRunPrivate as its member variables also cannot be used in KRun static methods. Could you give me a hint what do you mean exactly?


- Jan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129399/#review101128
-----------------------------------------------------------


On Lis. 22, 2016, 12:13 odp., Jan Grulich wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129399/
> -----------------------------------------------------------
> 
> (Updated Lis. 22, 2016, 12:13 odp.)
> 
> 
> Review request for KDE Frameworks and David Faure.
> 
> 
> Repository: kio
> 
> 
> Description
> -------
> 
> When running an app using KRun, check whether X-KDE-RunOnDiscreteGpu is set and whether we have a discrete graphics card and set the environment variable accordingly.
> 
> 
> Diffs
> -----
> 
>   src/widgets/krun.cpp d93b1f2 
> 
> Diff: https://git.reviewboard.kde.org/r/129399/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Jan Grulich
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20161128/09fc3709/attachment-0001.html>