Review Request 129399: Take X-KDE-RunOnDiscreteGpu property into account when starting app using KRun

[David Faure]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129399/#review101128
-----------------------------------------------------------




src/widgets/krun.cpp (line 436)
<https://git.reviewboard.kde.org/r/129399/#comment67775>

    Is it needed to do this check more than once?
    If this can't change over time, there could be a static enum here (not check yet, present, absent) to avoid making a dbus blocking call every time.


- David Faure


On Nov. 22, 2016, 12:13 p.m., Jan Grulich wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129399/
> -----------------------------------------------------------
> 
> (Updated Nov. 22, 2016, 12:13 p.m.)
> 
> 
> Review request for KDE Frameworks and David Faure.
> 
> 
> Repository: kio
> 
> 
> Description
> -------
> 
> When running an app using KRun, check whether X-KDE-RunOnDiscreteGpu is set and whether we have a discrete graphics card and set the environment variable accordingly.
> 
> 
> Diffs
> -----
> 
>   src/widgets/krun.cpp d93b1f2 
> 
> Diff: https://git.reviewboard.kde.org/r/129399/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Jan Grulich
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20161126/a5826157/attachment.html>