Review Request 129389: KRecentFilesAction: improve addUrl() apidox
Aleix Pol Gonzalez
aleixpol at kde.org
Mon Nov 14 23:22:10 UTC 2016
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129389/#review100846
-----------------------------------------------------------
src/krecentfilesaction.h (line 146)
<https://git.reviewboard.kde.org/r/129389/#comment67678>
How about this?
```
/**
* Adds a URL to the recent files list.
*
* @param url The URL of the file
* @param name The user visible pretty name that appears before the URL
*
* @note this will create a new QAction instance.
*/
```
- Aleix Pol Gonzalez
On Nov. 13, 2016, 12:33 p.m., Elvis Angelaccio wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129389/
> -----------------------------------------------------------
>
> (Updated Nov. 13, 2016, 12:33 p.m.)
>
>
> Review request for KDE Frameworks.
>
>
> Repository: kconfigwidgets
>
>
> Description
> -------
>
> If we add an url to the recent files list, the recentFilesAction will be enabled. This makes sense but can be unexpected (e.g. if one manually disabled the action), so add it to the apidox of the method.
>
>
> Diffs
> -----
>
> src/krecentfilesaction.h c13c81f8e3c334e3efe229c8befcc50be37a75a0
>
> Diff: https://git.reviewboard.kde.org/r/129389/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Elvis Angelaccio
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20161114/04ff4eab/attachment-0001.html>
More information about the Kde-frameworks-devel
mailing list