Review Request 129389: KRecentFilesAction: improve addUrl() apidox

Elvis Angelaccio elvis.angelaccio at kde.org
Mon Nov 14 11:25:49 UTC 2016



> On Nov. 13, 2016, 11:26 p.m., Aleix Pol Gonzalez wrote:
> > I'm not sure that it makes sense, or maybe it just reads weird.

What about putting it in a @note below? Or do you want a different wording?


- Elvis


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129389/#review100824
-----------------------------------------------------------


On Nov. 13, 2016, 11:33 a.m., Elvis Angelaccio wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129389/
> -----------------------------------------------------------
> 
> (Updated Nov. 13, 2016, 11:33 a.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kconfigwidgets
> 
> 
> Description
> -------
> 
> If we add an url to the recent files list, the recentFilesAction will be enabled. This makes sense but can be unexpected (e.g. if one manually disabled the action), so add it to the apidox of the method.
> 
> 
> Diffs
> -----
> 
>   src/krecentfilesaction.h c13c81f8e3c334e3efe229c8befcc50be37a75a0 
> 
> Diff: https://git.reviewboard.kde.org/r/129389/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Elvis Angelaccio
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20161114/b26cb56b/attachment-0001.html>


More information about the Kde-frameworks-devel mailing list