Review Request 129382: kconfig_compiler - generate code with overrides

Allen Winter winter at kde.org
Sat Nov 12 13:51:37 UTC 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129382/
-----------------------------------------------------------

(Updated Nov. 12, 2016, 1:51 p.m.)


Status
------

This change has been marked as submitted.


Review request for KDE Frameworks.


Changes
-------

Submitted with commit b66da09e586dda28ca43c6566904a0f62a787863 by Allen Winter to branch master.


Repository: kconfig


Description
-------

With this patch kconfig_compiler will add and override to usrSave method in the generated code.  then when compiling the generated code you can use the -Wsuggest-override option and you won't get warnings


Diffs
-----

  autotests/kconfig_compiler/test_signal.h.ref e536181 
  src/kconfig_compiler/kconfig_compiler.cpp 4494e45 

Diff: https://git.reviewboard.kde.org/r/129382/diff/


Testing
-------

make test works. notice this patch contains a fix for a reference file in the test suite


Thanks,

Allen Winter

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20161112/af3eec7f/attachment.html>


More information about the Kde-frameworks-devel mailing list