Review Request 129382: kconfig_compiler - generate code with overrides
Aleix Pol Gonzalez
aleixpol at kde.org
Fri Nov 11 23:36:50 UTC 2016
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129382/#review100795
-----------------------------------------------------------
Ship it!
Ship It!
- Aleix Pol Gonzalez
On Nov. 11, 2016, 11:34 p.m., Allen Winter wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129382/
> -----------------------------------------------------------
>
> (Updated Nov. 11, 2016, 11:34 p.m.)
>
>
> Review request for KDE Frameworks.
>
>
> Repository: kconfig
>
>
> Description
> -------
>
> With this patch kconfig_compiler will add and override to usrSave method in the generated code. then when compiling the generated code you can use the -Wsuggest-override option and you won't get warnings
>
>
> Diffs
> -----
>
> autotests/kconfig_compiler/test_signal.h.ref e536181
> src/kconfig_compiler/kconfig_compiler.cpp 4494e45
>
> Diff: https://git.reviewboard.kde.org/r/129382/diff/
>
>
> Testing
> -------
>
> make test works. notice this patch contains a fix for a reference file in the test suite
>
>
> Thanks,
>
> Allen Winter
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20161111/6adb1051/attachment.html>
More information about the Kde-frameworks-devel
mailing list