Review Request 129374: ktexteditor add overrides

[Dominik Haumann]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129374/#review100782
-----------------------------------------------------------


Ship it!




Ship It!

- Dominik Haumann


On Nov. 10, 2016, 10:56 p.m., Allen Winter wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129374/
> -----------------------------------------------------------
> 
> (Updated Nov. 10, 2016, 10:56 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: ktexteditor
> 
> 
> Description
> -------
> 
> Add Q_DECL_OVERRIDES as suggested by -Wsuggest-override
> 
> 
> Diffs
> -----
> 
>   src/vimode/emulatedcommandbar/commandmode.h 737a7d6 
>   src/vimode/emulatedcommandbar/interactivesedreplacemode.h f6c1741 
>   src/vimode/emulatedcommandbar/searchmode.h 92235e7 
> 
> Diff: https://git.reviewboard.kde.org/r/129374/diff/
> 
> 
> Testing
> -------
> 
> all warnings for -Wsuggest-override are gone
> make test still passes
> 
> 
> Thanks,
> 
> Allen Winter
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20161111/f91a0026/attachment.html>