Review Request 129374: ktexteditor add overrides

Allen Winter winter at kde.org
Thu Nov 10 22:56:26 UTC 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129374/
-----------------------------------------------------------

(Updated Nov. 10, 2016, 10:56 p.m.)


Review request for KDE Frameworks.


Repository: ktexteditor


Description
-------

Add Q_DECL_OVERRIDES as suggested by -Wsuggest-override


Diffs
-----

  src/vimode/emulatedcommandbar/commandmode.h 737a7d6 
  src/vimode/emulatedcommandbar/interactivesedreplacemode.h f6c1741 
  src/vimode/emulatedcommandbar/searchmode.h 92235e7 

Diff: https://git.reviewboard.kde.org/r/129374/diff/


Testing (updated)
-------

all warnings for -Wsuggest-override are gone
make test still passes


Thanks,

Allen Winter

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20161110/15d98e8c/attachment.html>


More information about the Kde-frameworks-devel mailing list