Review Request 129361: Add library path so utempter binary is found in Ubuntu 16.10
Albert Astals Cid
aacid at kde.org
Tue Nov 8 12:24:58 UTC 2016
> On Nov. 8, 2016, 11:57 a.m., Anthony Fieroni wrote:
> > cmake/FindUTEMPTER.cmake, line 43
> > <https://git.reviewboard.kde.org/r/129361/diff/1/?file=484356#file484356line43>
> >
> > I think we shouldn't search in fixed path i.e. /usr/...
> > ${CMAKE_PREFIX_PATH}/lib/${CMAKE_LIBRARY_ARCHITECTURE}/utempter
> > So "patch" like above one is error prone
So how do you suggest we fix the fact that the utempter library is not found for me?
- Albert
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129361/#review100712
-----------------------------------------------------------
On Nov. 7, 2016, 11:02 p.m., Albert Astals Cid wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129361/
> -----------------------------------------------------------
>
> (Updated Nov. 7, 2016, 11:02 p.m.)
>
>
> Review request for KDE Frameworks, Jonathan Riddell and Rex Dieter.
>
>
> Repository: kpty
>
>
> Description
> -------
>
> Read the summary
>
>
> Diffs
> -----
>
> cmake/FindUTEMPTER.cmake d3236c8
>
> Diff: https://git.reviewboard.kde.org/r/129361/diff/
>
>
> Testing
> -------
>
> Works
>
>
> Thanks,
>
> Albert Astals Cid
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20161108/c754114e/attachment.html>
More information about the Kde-frameworks-devel
mailing list