Review Request 129361: Add library path so utempter binary is found in Ubuntu 16.10

Anthony Fieroni bvbfan at abv.bg
Tue Nov 8 11:57:26 UTC 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129361/#review100712
-----------------------------------------------------------




cmake/FindUTEMPTER.cmake (line 43)
<https://git.reviewboard.kde.org/r/129361/#comment67609>

    I think we shouldn't search in fixed path i.e. /usr/...
    ${CMAKE_PREFIX_PATH}/lib/${CMAKE_LIBRARY_ARCHITECTURE}/utempter
    So "patch" like above one is error prone


- Anthony Fieroni


On Nov. 8, 2016, 1:02 a.m., Albert Astals Cid wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129361/
> -----------------------------------------------------------
> 
> (Updated Nov. 8, 2016, 1:02 a.m.)
> 
> 
> Review request for KDE Frameworks, Jonathan Riddell and Rex Dieter.
> 
> 
> Repository: kpty
> 
> 
> Description
> -------
> 
> Read the summary
> 
> 
> Diffs
> -----
> 
>   cmake/FindUTEMPTER.cmake d3236c8 
> 
> Diff: https://git.reviewboard.kde.org/r/129361/diff/
> 
> 
> Testing
> -------
> 
> Works
> 
> 
> Thanks,
> 
> Albert Astals Cid
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20161108/493eabc9/attachment.html>


More information about the Kde-frameworks-devel mailing list