Review Request 128902: [Kauth] - Add timeout property
stephane cachemaille
stephane at scachemaille.ch
Mon Nov 7 14:21:44 UTC 2016
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128902/
-----------------------------------------------------------
(Updated Nov. 7, 2016, 3:21 p.m.)
Review request for KDE Frameworks.
Changes
-------
No need to list everyone, just link to the kdeframeworks group.
Bugs: 363200
https://bugs.kde.org/show_bug.cgi?id=363200
Repository: kauth
Description
-------
Add timeout property to Kauth::Action class to be able to change the timeout in QDBusConnection::asyncCall
Diffs
-----
src/HelperProxy.h 96f4cf1
src/backends/dbus/DBusHelperProxy.h 8f4254c
src/backends/dbus/DBusHelperProxy.cpp d2620ac
src/backends/fakehelper/FakeHelperProxy.h d0fb3f5
src/backends/fakehelper/FakeHelperProxy.cpp a044ac6
src/kauthaction.h 4e33366
src/kauthaction.cpp 34f559d
src/kauthexecutejob.cpp 8b6e177
Diff: https://git.reviewboard.kde.org/r/128902/diff/
Testing
-------
tested with and without using the new proporty in a kcm module where the action takes more than the default 25s
Thanks,
stephane cachemaille
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20161107/6e58cb1b/attachment-0001.html>
More information about the Kde-frameworks-devel
mailing list