Review Request 129356: kdesignerplugin - add overrides to the generated source
Allen Winter
winter at kde.org
Mon Nov 7 12:48:15 UTC 2016
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129356/
-----------------------------------------------------------
(Updated Nov. 7, 2016, 1:48 p.m.)
Status
------
This change has been marked as submitted.
Review request for KDE Frameworks.
Changes
-------
Submitted with commit 606352070ae07bd5c7fe6e2702628632b8245c9b by Allen Winter to branch master.
Repository: kdesignerplugin
Description
-------
add Q_DECL_OVERRIDE to the kgendesignerplugin.cpp generated code so -Wsuggest-overrides doesn't complain
Diffs
-----
src/kgendesignerplugin.cpp 33326d0
Diff: https://git.reviewboard.kde.org/r/129356/diff/
Testing
-------
The generated code can be compiled with -Wsuggest-overrides without complaining.
make test passes
also removed tabs from the generated source code
Thanks,
Allen Winter
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20161107/6ac93281/attachment.html>
More information about the Kde-frameworks-devel
mailing list