Review Request 129356: kdesignerplugin - add overrides to the generated source

[David Faure]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129356/#review100672
-----------------------------------------------------------


Ship it!




Ship It!

- David Faure


On Nov. 6, 2016, 10:30 p.m., Allen Winter wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129356/
> -----------------------------------------------------------
> 
> (Updated Nov. 6, 2016, 10:30 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kdesignerplugin
> 
> 
> Description
> -------
> 
> add Q_DECL_OVERRIDE to the kgendesignerplugin.cpp generated code so -Wsuggest-overrides doesn't complain
> 
> 
> Diffs
> -----
> 
>   src/kgendesignerplugin.cpp 33326d0 
> 
> Diff: https://git.reviewboard.kde.org/r/129356/diff/
> 
> 
> Testing
> -------
> 
> The generated code can be compiled with -Wsuggest-overrides without complaining.
> make test passes
> 
> also removed tabs from the generated source code
> 
> 
> Thanks,
> 
> Allen Winter
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20161106/404e35d1/attachment.html>