[Differential] [Changed Subscribers] D3226: Don't be fatal on File field not being properly parsed

kfunk (Kevin Funk) noreply at phabricator.kde.org
Wed Nov 2 12:29:20 UTC 2016


kfunk added inline comments.

INLINE COMMENTS

> KF5ConfigMacros.cmake:71
>         file(READ ${_tmp_FILE} _contents)
> -       string(REGEX MATCH "File=([^\n]+\\.kcfg)\n" "" "${_contents}")
> +       string(REGEX MATCH "File=([^\n]+\\.kcfg)c?\n" "" "${_contents}")
>         set(_kcfg_FILENAME "${CMAKE_MATCH_1}")

I suggest to add some commentary here.

REVISION DETAIL
  https://phabricator.kde.org/D3226

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: apol, #frameworks
Cc: kfunk
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20161102/e92b30b5/attachment.html>


More information about the Kde-frameworks-devel mailing list