Review Request 129302: Fix include dir in pri file

David Rosca nowrep at gmail.com
Tue Nov 1 08:39:10 UTC 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129302/
-----------------------------------------------------------

(Updated Nov. 1, 2016, 11:39 a.m.)


Status
------

This change has been marked as submitted.


Review request for KDE Frameworks and Jan Grulich.


Changes
-------

Submitted with commit 4e295bcf03d3964d5675894053190a71a5288baa by David Rosca to branch master.


Repository: networkmanager-qt


Description
-------

Currently the pri file has Qt.NetworkManagerQt.includes = /usr/include/NetworkManagerQt.
This changes fixes it and makes it /usr/include/KF5/NetworkManagerQt


Diffs
-----

  src/CMakeLists.txt 3249154 

Diff: https://git.reviewboard.kde.org/r/129302/diff/


Testing
-------

Correct include paths when used from qmake.
It still cannot be used from qmake without additional changes because `generictypes.h` includes `nm-version.h` from libnm which is not in include paths.


Thanks,

David Rosca

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20161101/fe7013ea/attachment.html>


More information about the Kde-frameworks-devel mailing list