Review Request 129302: Fix include dir in pri file

Jan Grulich jgrulich at redhat.com
Tue Nov 1 08:34:48 UTC 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129302/#review100459
-----------------------------------------------------------


Ship it!




Not only generictypes.h includes NM headers, they are used in many places.

- Jan Grulich


On Lis. 1, 2016, 8:24 dop., David Rosca wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129302/
> -----------------------------------------------------------
> 
> (Updated Lis. 1, 2016, 8:24 dop.)
> 
> 
> Review request for KDE Frameworks and Jan Grulich.
> 
> 
> Repository: networkmanager-qt
> 
> 
> Description
> -------
> 
> Currently the pri file has Qt.NetworkManagerQt.includes = /usr/include/NetworkManagerQt.
> This changes fixes it and makes it /usr/include/KF5/NetworkManagerQt
> 
> 
> Diffs
> -----
> 
>   src/CMakeLists.txt 3249154 
> 
> Diff: https://git.reviewboard.kde.org/r/129302/diff/
> 
> 
> Testing
> -------
> 
> Correct include paths when used from qmake.
> It still cannot be used from qmake without additional changes because `generictypes.h` includes `nm-version.h` from libnm which is not in include paths.
> 
> 
> Thanks,
> 
> David Rosca
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20161101/2c7553f5/attachment.html>


More information about the Kde-frameworks-devel mailing list