Review Request 128057: Don't initialize KNS3::DownloadManager with the wrong categories

Aleix Pol Gonzalez aleixpol at kde.org
Tue May 31 22:14:51 UTC 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128057/
-----------------------------------------------------------

(Updated June 1, 2016, 1:14 a.m.)


Status
------

This change has been marked as submitted.


Review request for KDE Frameworks and Jeremy Whiting.


Changes
-------

Submitted with commit ed0a1be18ec5b421fc1319d2a28f118d9ea324b9 by Aleix Pol to branch master.


Repository: knewstuff


Description
-------

If we request some unexisting categories, we'll get basically a list of all resources in the OCS server, which is not what we want.
For now, just emit an error instead so the front-end can react to it.


Diffs
-----

  src/attica/atticaprovider.cpp 94f869e 
  src/downloadmanager.h 0441742 
  src/downloadmanager.cpp 9eca302 

Diff: https://git.reviewboard.kde.org/r/128057/diff/


Testing
-------

Tested with Plasma's comic.knsrc file and Discover, which triggers this problem.


Thanks,

Aleix Pol Gonzalez

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160531/7abe6a59/attachment-0001.html>


More information about the Kde-frameworks-devel mailing list