Review Request 128057: Don't initialize KNS3::DownloadManager with the wrong categories

[Jeremy Whiting]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128057/#review96108
-----------------------------------------------------------


Ship it!




Ship It!

- Jeremy Whiting


On May 30, 2016, 9:12 a.m., Aleix Pol Gonzalez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128057/
> -----------------------------------------------------------
> 
> (Updated May 30, 2016, 9:12 a.m.)
> 
> 
> Review request for KDE Frameworks and Jeremy Whiting.
> 
> 
> Repository: knewstuff
> 
> 
> Description
> -------
> 
> If we request some unexisting categories, we'll get basically a list of all resources in the OCS server, which is not what we want.
> For now, just emit an error instead so the front-end can react to it.
> 
> 
> Diffs
> -----
> 
>   src/attica/atticaprovider.cpp 94f869e 
>   src/downloadmanager.h 0441742 
>   src/downloadmanager.cpp 9eca302 
> 
> Diff: https://git.reviewboard.kde.org/r/128057/diff/
> 
> 
> Testing
> -------
> 
> Tested with Plasma's comic.knsrc file and Discover, which triggers this problem.
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160531/4fa63615/attachment-0001.html>