Review Request 128036: Fix default encoding to UTF-8

Christoph Cullmann cullmann at kde.org
Sat May 28 16:36:53 UTC 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128036/
-----------------------------------------------------------

(Updated May 28, 2016, 4:36 p.m.)


Review request for Kate and KDE Frameworks.


Changes
-------

added bug in Bugs field


Bugs: 362604
    https://bugs.kde.org/show_bug.cgi?id=362604


Repository: ktexteditor


Description
-------

Fix default encoding to UTF-8 instead of using system locale.
The whole encoding detection only works nicely, if the default is something like UTF-8 that clashs with other encodings.
If the user has bad luck and some unfortunate system encoding like latin1, no detection will work.
See bug report https://bugs.kde.org/show_bug.cgi?id=362604

Given that most unices anyways default to UTF-8, I don't think this should hurt.


Diffs
-----

  src/utils/kateconfig.cpp 20a59d0 

Diff: https://git.reviewboard.kde.org/r/128036/diff/


Testing
-------

make && make test


Thanks,

Christoph Cullmann

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160528/bfdd2208/attachment.html>


More information about the Kde-frameworks-devel mailing list