Review Request 128036: Fix default encoding to UTF-8

[Dominik Haumann]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128036/#review95953
-----------------------------------------------------------


Ship it!




Yes, this will work on Windows, and imho is the correct fix.

Btw, in the encoding combo box, we also have an entry called "KDE Default". This default is completely intransparent, especially on Windows, where the term "KDE" doesn't make much sense. As I understand, the KDE default is probably set in system settings, but even this is a bit fuzzy in KDE, since in Kate the user still doesn't see what's really going on.

Anyways, this patch is good, please commit ;)

- Dominik Haumann


On May 28, 2016, 3:09 p.m., Christoph Cullmann wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128036/
> -----------------------------------------------------------
> 
> (Updated May 28, 2016, 3:09 p.m.)
> 
> 
> Review request for Kate and KDE Frameworks.
> 
> 
> Repository: ktexteditor
> 
> 
> Description
> -------
> 
> Fix default encoding to UTF-8 instead of using system locale.
> The whole encoding detection only works nicely, if the default is something like UTF-8 that clashs with other encodings.
> If the user has bad luck and some unfortunate system encoding like latin1, no detection will work.
> See bug report https://bugs.kde.org/show_bug.cgi?id=362604
> 
> Given that most unices anyways default to UTF-8, I don't think this should hurt.
> 
> 
> Diffs
> -----
> 
>   src/utils/kateconfig.cpp 20a59d0 
> 
> Diff: https://git.reviewboard.kde.org/r/128036/diff/
> 
> 
> Testing
> -------
> 
> make && make test
> 
> 
> Thanks,
> 
> Christoph Cullmann
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160528/27b4c8f5/attachment.html>