kptyprocesstest is still flaky
Oswald Buddenhagen
oswald.buddenhagen at gmx.de
Tue May 24 07:51:51 UTC 2016
On Sun, May 22, 2016 at 03:59:59PM +0200, David Faure wrote:
> The CI for KF5 is now all green except for kpty which is still flaky.
>
> https://build.kde.org/view/Frameworks%20kf5-qt5/job/kpty%20master%20stable-kf5-qt5/42/PLATFORM=Linux,compiler=gcc/testReport/junit/%28root%29/TestSuite/kptyprocesstest/
>
> Same failure as a few years ago:
>
> FAIL! : KPtyProcessTest::test_pty_signals() Compared values are not the same
> Actual (QLatin1String(log)) : "<<<>bla\r\n$\n>foobar\r\n$\n!\n<>fooish\r\n$\n>bar\r\n$\n!\n<|$\n"
> Expected (QLatin1String(want)): "<>bla\r\n$\n!\n<!\n<>foobar\r\n$\n!\n<>fooish\r\n$\n>bar\r\n$\n!\n<|$\n"
> Loc: [/home/jenkins/sources/kpty/stable-kf5-qt5/autotests/kptyprocesstest.cpp(201)]
>
> I can reproduce it locally if I run the test in a loop.
>
> Is this worth fixing, or should we just disable the test?
>
the test certainly is worth keeping.
you may get lucky with increasing the step timer to 100 ms.
of course, that isn't a real fix, but that would be a lot more complex
(it would be necessary to have a handshake channel with the other end,
which implies a custom executable instead of cat).
More information about the Kde-frameworks-devel
mailing list