kptyprocesstest is still flaky

[Albert Astals Cid]

El diumenge, 22 de maig de 2016, a les 15:59:59 CEST, David Faure va escriure:
> The CI for KF5 is now all green except for kpty which is still flaky.
> 
> https://build.kde.org/view/Frameworks%20kf5-qt5/job/kpty%20master%20stable-k
> f5-qt5/42/PLATFORM=Linux,compiler=gcc/testReport/junit/%28root%29/TestSuite/
> kptyprocesstest/
> 
> Same failure as a few years ago:
> 
> FAIL!  : KPtyProcessTest::test_pty_signals() Compared values are not the
> same Actual   (QLatin1String(log)) :
> "<<<>bla\r\n$\n>foobar\r\n$\n!\n<>fooish\r\n$\n>bar\r\n$\n!\n<|$\n"
> Expected (QLatin1String(want)):
> "<>bla\r\n$\n!\n<!\n<>foobar\r\n$\n!\n<>fooish\r\n$\n>bar\r\n$\n!\n<|$\n"
> Loc:
> [/home/jenkins/sources/kpty/stable-kf5-qt5/autotests/kptyprocesstest.cpp(20
> 1)]
> 
> I can reproduce it locally if I run the test in a loop.
> 
> Is this worth fixing, or should we just disable the test?

If we disable the test we should add a comment somewhere to the headers saying 
"this doesn't work, don't use me" (unless it is the test that is wrong).

Cheers,
  Albert

> Ossi?