Review Request 127988: [runtime] Link KF5::Crash in the binary not in the private library

Martin Gräßlin mgraesslin at kde.org
Mon May 23 05:46:03 UTC 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127988/
-----------------------------------------------------------

(Updated May 23, 2016, 5:46 a.m.)


Status
------

This change has been marked as submitted.


Review request for KDE Frameworks.


Changes
-------

Submitted with commit 0f50e128929bc208ee672590a1a8db285335d3e5 by Martin Gräßlin to branch master.


Repository: kglobalaccel


Description
-------

KCrash is only used by the kglobalacceld5 binary, but not in the
private library. So don't link it in the library as otherwise it's
get pulled into applications using the private library, but don't
want to use KCrash (example kwin_wayland).


Diffs
-----

  src/runtime/CMakeLists.txt 50f64935657fda61b246610246977c19c6563147 

Diff: https://git.reviewboard.kde.org/r/127988/diff/


Testing
-------


Thanks,

Martin Gräßlin

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160523/0c924900/attachment.html>


More information about the Kde-frameworks-devel mailing list