Review Request 127988: [runtime] Link KF5::Crash in the binary not in the private library

[David Edmundson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127988/#review95703
-----------------------------------------------------------


Ship it!




Ship It!

- David Edmundson


On May 22, 2016, 3:36 p.m., Martin Gräßlin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127988/
> -----------------------------------------------------------
> 
> (Updated May 22, 2016, 3:36 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kglobalaccel
> 
> 
> Description
> -------
> 
> KCrash is only used by the kglobalacceld5 binary, but not in the
> private library. So don't link it in the library as otherwise it's
> get pulled into applications using the private library, but don't
> want to use KCrash (example kwin_wayland).
> 
> 
> Diffs
> -----
> 
>   src/runtime/CMakeLists.txt 50f64935657fda61b246610246977c19c6563147 
> 
> Diff: https://git.reviewboard.kde.org/r/127988/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160522/fee4e693/attachment-0001.html>