Review Request 127931: Kdelibs4ConfigMigrator: skip reparsing if nothing was migrated.

[David Faure]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127931/
-----------------------------------------------------------

(Updated May 15, 2016, 7:04 p.m.)


Status
------

This change has been marked as submitted.


Review request for KDE Frameworks and Laurent Montel.


Changes
-------

Submitted with commit 80c6bd7198726bf8c8d7f9dba98347dd3459d682 by David Faure to branch master.


Repository: kcoreaddons


Description
-------

This improves performance greatly for crazy PIM people calling
this code in an often-called constructor :-)


Diffs
-----

  src/lib/util/kdelibs4configmigrator.cpp acdb19cfd84b46a1a6e4cf1ead3a32354145e7ae 

Diff: https://git.reviewboard.kde.org/r/127931/diff/


Testing
-------

Found by callgrind'ing kmail. Not actually tested other than compilation and kcoreaddons unit tests, but seems clear enough.


Thanks,

David Faure

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160515/b823866d/attachment.html>