Review Request 127931: Kdelibs4ConfigMigrator: skip reparsing if nothing was migrated.

[David Faure]

> On May 15, 2016, 5:52 p.m., Laurent Montel wrote:
> > Seems ok for me.
> > Could you convert qDebug() to qCDebug ?
> > 
> > After fixing it ship it :)
> > 
> > Regards.

The qDebug was already there (I only fixed the white spaces) so this is unrelated to the commit. But OK I'll convert that file to qCDebug in a separate commit.


- David


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127931/#review95486
-----------------------------------------------------------


On May 15, 2016, 4:55 p.m., David Faure wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127931/
> -----------------------------------------------------------
> 
> (Updated May 15, 2016, 4:55 p.m.)
> 
> 
> Review request for KDE Frameworks and Laurent Montel.
> 
> 
> Repository: kcoreaddons
> 
> 
> Description
> -------
> 
> This improves performance greatly for crazy PIM people calling
> this code in an often-called constructor :-)
> 
> 
> Diffs
> -----
> 
>   src/lib/util/kdelibs4configmigrator.cpp acdb19cfd84b46a1a6e4cf1ead3a32354145e7ae 
> 
> Diff: https://git.reviewboard.kde.org/r/127931/diff/
> 
> 
> Testing
> -------
> 
> Found by callgrind'ing kmail. Not actually tested other than compilation and kcoreaddons unit tests, but seems clear enough.
> 
> 
> Thanks,
> 
> David Faure
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160515/ff718dcb/attachment-0001.html>