Review Request 127860: kauth: helperDebugHandler is not handling QtInfoMsg

Allen Winter winter at kde.org
Sun May 8 12:23:04 UTC 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127860/
-----------------------------------------------------------

(Updated May 8, 2016, 12:23 p.m.)


Review request for KDE Frameworks.


Changes
-------

now syslogs LOG_INFO in the QtInfoMsg case.  Also I updated the LOG_foo values on Windows to agree with what i have in my linux sys/syslog.h


Repository: kauth


Description
-------

This patch fixes the -Wswitch warning by adding a case for QtInfoMsg in HelperSupport::helperDebugHandler.  Question is what do we want to do in the case of an info message?  do we want to syslog info messages or ignore them?


Diffs (updated)
-----

  src/kauthhelpersupport.cpp c2a88d7 

Diff: https://git.reviewboard.kde.org/r/127860/diff/


Testing
-------

compiles now without a -Wswitch warning.


Thanks,

Allen Winter

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160508/c08187d7/attachment.html>


More information about the Kde-frameworks-devel mailing list