Review Request 127860: kauth: helperDebugHandler is not handling QtInfoMsg

[Michael Pyne]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127860/#review95267
-----------------------------------------------------------


Fix it, then Ship it!




Use LOG_INFO (and add LOG_INFO to the Windows-compat #defines) and this should be golden.


src/kauthhelpersupport.cpp (line 126)
<https://git.reviewboard.kde.org/r/127860/#comment64622>

    syslog.h defines LOG_INFO so I'd recommend using that here, just keep in mind that we'll need to add a definition for LOG_INFO near the top of the file with the other Windows-compatibility syslog defines.


- Michael Pyne


On May 7, 2016, 3:35 p.m., Allen Winter wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127860/
> -----------------------------------------------------------
> 
> (Updated May 7, 2016, 3:35 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kauth
> 
> 
> Description
> -------
> 
> This patch fixes the -Wswitch warning by adding a case for QtInfoMsg in HelperSupport::helperDebugHandler.  Question is what do we want to do in the case of an info message?  do we want to syslog info messages or ignore them?
> 
> 
> Diffs
> -----
> 
>   src/kauthhelpersupport.cpp c2a88d7 
> 
> Diff: https://git.reviewboard.kde.org/r/127860/diff/
> 
> 
> Testing
> -------
> 
> compiles now without a -Wswitch warning.
> 
> 
> Thanks,
> 
> Allen Winter
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160507/002952bc/attachment-0001.html>