Review Request 127806: Q_BYTE_ORDER not defined in the kwallet backends

Allen Winter winter at kde.org
Sat May 7 14:54:26 UTC 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127806/
-----------------------------------------------------------

(Updated May 7, 2016, 2:54 p.m.)


Status
------

This change has been marked as submitted.


Review request for KDE Frameworks and Valentin Rusu.


Changes
-------

Submitted with commit b3a95ba0540e01a9bb10db53fc449cc49ce9a9e8 by Allen Winter to branch master.


Repository: kwallet


Description
-------

the kwalletd backends (blowfish and sha1) rely on Q_BYTE_ORDER being defined.  Since it looks like we want to keep sha1.cc and blowfish.cc "Qt-clean" I put the include for QtCore/qglobal.h into the config-kwalletbackend.h.


Diffs
-----

  src/runtime/kwalletd/backend/blowfish.cc a375148 
  src/runtime/kwalletd/backend/sha1.cc 9d98b79 

Diff: https://git.reviewboard.kde.org/r/127806/diff/


Testing
-------

compiles. now Q_BYTE_ORDER is defined by qglobal.h


Thanks,

Allen Winter

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160507/603f07e8/attachment.html>


More information about the Kde-frameworks-devel mailing list