Review Request 127806: Q_BYTE_ORDER not defined in the kwallet backends

[David Faure]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127806/#review95263
-----------------------------------------------------------


Ship it!




Ship It!

- David Faure


On May 7, 2016, 2:25 p.m., Allen Winter wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127806/
> -----------------------------------------------------------
> 
> (Updated May 7, 2016, 2:25 p.m.)
> 
> 
> Review request for KDE Frameworks and Valentin Rusu.
> 
> 
> Repository: kwallet
> 
> 
> Description
> -------
> 
> the kwalletd backends (blowfish and sha1) rely on Q_BYTE_ORDER being defined.  Since it looks like we want to keep sha1.cc and blowfish.cc "Qt-clean" I put the include for QtCore/qglobal.h into the config-kwalletbackend.h.
> 
> 
> Diffs
> -----
> 
>   src/runtime/kwalletd/backend/blowfish.cc a375148 
>   src/runtime/kwalletd/backend/sha1.cc 9d98b79 
> 
> Diff: https://git.reviewboard.kde.org/r/127806/diff/
> 
> 
> Testing
> -------
> 
> compiles. now Q_BYTE_ORDER is defined by qglobal.h
> 
> 
> Thanks,
> 
> Allen Winter
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160507/0ee9ce7f/attachment.html>