Review Request 127806: Q_BYTE_ORDER not defined in the kwallet backends

[David Faure]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127806/#review95250
-----------------------------------------------------------



You say: since it looks like we want to keep sha1.cc and blowfish.cc "Qt-clean"

Clearly that is not the case, if they use Q_BYTE_ORDER. So if it's OK for them to use Q_BYTE_ORDER, it's ok for them to include qglobal.h.
I don't see any reason to do so in the cmake-generated header file.

- David Faure


On May 1, 2016, 7:50 p.m., Allen Winter wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127806/
> -----------------------------------------------------------
> 
> (Updated May 1, 2016, 7:50 p.m.)
> 
> 
> Review request for KDE Frameworks and Valentin Rusu.
> 
> 
> Repository: kwallet
> 
> 
> Description
> -------
> 
> the kwalletd backends (blowfish and sha1) rely on Q_BYTE_ORDER being defined.  Since it looks like we want to keep sha1.cc and blowfish.cc "Qt-clean" I put the include for QtCore/qglobal.h into the config-kwalletbackend.h.
> 
> 
> Diffs
> -----
> 
>   src/runtime/kwalletd/backend/config-kwalletbackend.h.cmake 4705cd1 
> 
> Diff: https://git.reviewboard.kde.org/r/127806/diff/
> 
> 
> Testing
> -------
> 
> compiles. now Q_BYTE_ORDER is defined by qglobal.h
> 
> 
> Thanks,
> 
> Allen Winter
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160506/0d89005e/attachment.html>