Review Request 127806: Q_BYTE_ORDER not defined in the kwallet backends

Allen Winter winter at kde.org
Sun May 1 19:50:25 UTC 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127806/
-----------------------------------------------------------

(Updated May 1, 2016, 7:50 p.m.)


Review request for KDE Frameworks and Valentin Rusu.


Summary (updated)
-----------------

Q_BYTE_ORDER not defined in the kwallet backends


Repository: kwallet


Description
-------

the kwalletd backends (blowfish and sha1) rely on Q_BYTE_ORDER being defined.  Since it looks like we want to keep sha1.cc and blowfish.cc "Qt-clean" I put the include for QtCore/qglobal.h into the config-kwalletbackend.h.


Diffs
-----

  src/runtime/kwalletd/backend/config-kwalletbackend.h.cmake 4705cd1 

Diff: https://git.reviewboard.kde.org/r/127806/diff/


Testing
-------

compiles. now Q_BYTE_ORDER is defined by qglobal.h


Thanks,

Allen Winter

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160501/daf0b52d/attachment.html>


More information about the Kde-frameworks-devel mailing list