Review Request 127819: [autotests] Use -displayfd as argument to start Xvfb

Kai Uwe Broulik kde at privat.broulik.de
Tue May 3 10:59:53 UTC 2016



> On Mai 3, 2016, 10:38 vorm., Aleix Pol Gonzalez wrote:
> > autotests/netwininfotestwm.cpp, line 119
> > <https://git.reviewboard.kde.org/r/127819/diff/1/?file=464043#file464043line119>
> >
> >     You can drom the parenthesis: `QStringList({})` -> `QStringList{}`. It might call the copy constructor otherwise.

You can also just do {} if it isn't ambiguous


- Kai Uwe


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127819/#review95129
-----------------------------------------------------------


On Mai 3, 2016, 6:32 vorm., Martin Gräßlin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127819/
> -----------------------------------------------------------
> 
> (Updated Mai 3, 2016, 6:32 vorm.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kwindowsystem
> 
> 
> Description
> -------
> 
> Makes the test more reliable, our side blocks till the server is
> fully started.
> 
> The approach is used by KWin's autotest.
> 
> 
> Diffs
> -----
> 
>   autotests/netrootinfotestwm.cpp 3816ce2c0ff4ca7a6c5b1c37532e10f0fafec63c 
>   autotests/netwininfotestclient.cpp 222b5b1e959fa44bb2b242757ff32abf31b63be7 
>   autotests/netwininfotestwm.cpp 9670a14dcb8faebf2ac6af8d56ead3681fa11715 
> 
> Diff: https://git.reviewboard.kde.org/r/127819/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160503/193a2c30/attachment-0001.html>


More information about the Kde-frameworks-devel mailing list