Review Request 127819: [autotests] Use -displayfd as argument to start Xvfb

Aleix Pol Gonzalez aleixpol at kde.org
Tue May 3 10:38:08 UTC 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127819/#review95129
-----------------------------------------------------------



+1.


autotests/netwininfotestwm.cpp (line 119)
<https://git.reviewboard.kde.org/r/127819/#comment64563>

    You can drom the parenthesis: `QStringList({})` -> `QStringList{}`. It might call the copy constructor otherwise.


- Aleix Pol Gonzalez


On May 3, 2016, 8:32 a.m., Martin Gräßlin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127819/
> -----------------------------------------------------------
> 
> (Updated May 3, 2016, 8:32 a.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kwindowsystem
> 
> 
> Description
> -------
> 
> Makes the test more reliable, our side blocks till the server is
> fully started.
> 
> The approach is used by KWin's autotest.
> 
> 
> Diffs
> -----
> 
>   autotests/netrootinfotestwm.cpp 3816ce2c0ff4ca7a6c5b1c37532e10f0fafec63c 
>   autotests/netwininfotestclient.cpp 222b5b1e959fa44bb2b242757ff32abf31b63be7 
>   autotests/netwininfotestwm.cpp 9670a14dcb8faebf2ac6af8d56ead3681fa11715 
> 
> Diff: https://git.reviewboard.kde.org/r/127819/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160503/2f65d03f/attachment.html>


More information about the Kde-frameworks-devel mailing list